Added option to choose units for electricity and gas

nrocco / smeterd

Read P1 smart meter packets in Python

MIT License

31 stars 19 forks source link

Added option to choose units for electricity and gas #24

Closed tvwerkhoven closed 5 years ago

tvwerkhoven commented 5 years ago

Different units may serve different purposes. This allows easier pushing data in scripts to databases. E.g. I prefer my units to be SI, so I can choose which ones I use later on.

Electricity data works, gas is untested since I have no gas meter.

nrocco commented 5 years ago

As soon as I have a chance I will test this topic branch against my meter.

I haven’t looked in detail to the code yet. Is this PR backwards compatible?

tvwerkhoven commented 5 years ago

Ok! Yes the PR retains the defaults of the current script (I.e. Wh and m^3) and is backwards compatible.

On 6 Aug 2019, at 00:18, Nico notifications@github.com wrote:

As soon as I have a chance I will test this topic branch against my meter.

I haven’t looked in detail to the code yet. Is this PR backwards compatible?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

nrocco commented 5 years ago

Merged your efforts to master, I will create a new tag later today. Thanks for your efforts! Highly appreciated.