search

nrocco / smeterd

Read P1 smart meter packets in Python
MIT License
31 stars 18 forks source link

Corrected regex for parsing gas total #8

Closed Atrejoe closed 8 years ago

Atrejoe commented 8 years ago

Contains a general part (field identfier prefix) and specifically some for Kaifa meters (cubic meters indicator, unknown numeric prefix)

The regex seemded to missing a field indicator for 0-1:24.2.1 Furthermore my meter (and of @Koen01) seemded to have an extra prefixed field os some digits followed by 'S' and a cubic meters indicator, like: 0-1:24.2.1(160904220000S)(05290.211*m3)

Fixed by adding optional matching.

nrocco commented 8 years ago

Excellent work. Thanks for your contributions.

I will merge this pull request now and create a new package + upload to pypi next week.

Atrejoe commented 8 years ago

Hi @nrocco do you maybe see the chance to update the pypi package?

nrocco commented 8 years ago

@Atrejoe I have just created a new version of smeterd 2.5.0 which can be found on pypi here: https://pypi.python.org/pypi/smeterd/2.5.0

Atrejoe commented 8 years ago

Wow, that is a lightning response, thanks!