search

nroduit / Weasis

Weasis is a DICOM viewer available as a desktop application or as a web-based application.
https://nroduit.github.io
Other
828 stars 295 forks source link

GSPS is not rendered correctly in 3.7.0 #187

Closed Ch00k closed 3 years ago

Ch00k commented 3 years ago

Describe the bug The GSPS is only partially rendered in Weasis 3.7.0. The GSPS contains objects of different colors: white and blue. The white part shows fine, but the blue one does not. In Weasis 3.6.2 the entire GSPS is displayed correctly.

To Reproduce Steps to reproduce the behavior:

  1. Download weasis_gsps.zip, unpack and open the two DICOM files in Weasis.
  2. Select AIDENCE VEYE in GSPS dropdown menu.

Expected behavior Both the white and the blue parts of the GSPS are displayed correctly.

Desktop (please complete the following information):

Additional context This could be related to https://github.com/nroduit/Weasis/issues/181, however I also tried the 3.7.1 version that fixed the problem in https://github.com/nroduit/Weasis/issues/181, but it does not fix this problem.

Screenshots Weasis 3.7.0

370

Weasis 3.6.2

362
nroduit commented 3 years ago

Yes, the new version supports Pattern On Opacity Attribute and in your case the opacity value is 0.0 => transparent

Ch00k commented 3 years ago

@nroduit sorry, I'm not sure I understand what you mean exactly. You mean it's a feature, not a bug? Should I fix my GSPS instead to make the blue text non-transparent?

nroduit commented 3 years ago

Yes, I was wondering if it would be safer not to allow the value 0.0 but at the same time it is a valid value.

Ch00k commented 3 years ago

I changed the PatternOnOpacity to 1.0 which made Weasis render the GSPS correctly. I guess this issue can be closed now. Thanks a lot for looking at it!