search

nroduit / Weasis

Weasis is a DICOM viewer available as a desktop application or as a web-based application.
https://nroduit.github.io
Other
828 stars 295 forks source link

whats the reason for this code #198

Closed paytam closed 1 year ago

paytam commented 3 years ago

in class org.weasis.dicom.explorer.LocalImport method initialize protected void initialize(boolean afirst) { if (afirst) {} } if has no body, so you can remove the whole method. method usages are 2 points 1)constructor of class (initialize(true)) 2)in method resetSettingsToDefault() in that class, too(initialize(false))

nroduit commented 3 years ago

Yes for this particular page, there is no implementation for that method.

paytam commented 3 years ago

So is it safe to remove the method? or do you have some usages in future development?

On Wed, Jun 30, 2021 at 10:51 AM Nicolas Roduit @.***> wrote:

Yes for this particular page, there is no implementation for that method.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nroduit/Weasis/issues/198#issuecomment-871129377, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLW6RYJBN47THSYH7MDCWLTVKZX7ANCNFSM47P4URPA .

-- Best regards, Mohammad.S.Paytam

nroduit commented 3 years ago

I don't think so. You can make a pull request to clean this class.