Open DLPerf opened 3 years ago
Hello, I found a performance issue in the definition of create_models, pilco/controllers.py, tf.ones will be calculated repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.
create_models
The same issue exists in tf.ones in line 31 and tf.ones in line 19.
tf.ones
Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
Hello, I found a performance issue in the definition of
create_models, pilco/controllers.py, tf.ones will be calculated repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.The same issue exists in
tf.onesin line 31 andtf.onesin line 19.Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.