nroutasuo / level13

Incremental browser text adventure
Apache License 2.0
213 stars 71 forks source link

make offline pwa #291

Closed aeiea closed 1 year ago

aeiea commented 1 year ago

pls merge

nroutasuo commented 1 year ago

Hi there, thanks for the PR. I am not familiar with this technology and I'm a bit hesitant to merge in code that I don't fully understand myself. I'll look into it, but it might take awhile for this to get merged.

In the meanwhile perhaps you could answer the following:

aeiea commented 1 year ago

Benefits:

aeiea commented 1 year ago

I've also added a GitHub action workflow to automatically update the list of files.

aeiea commented 1 year ago

i just wasted my morning making a github actions workflow to automatically update the files

nroutasuo commented 1 year ago

I finally had a closer look at this now. Thanks the details and the update script. I appreciate the effort put into this and I learned a bunch as well. It all looks good, but I've decided not to merge this now. I think at this stage the maintenance will outweight the benefits.

However I would like to come back to this later if and when adding better mobile support for the game in general.

aeiea commented 1 year ago

kay