search

nrupatunga / PY-GOTURN

This is the python-caffe implementation of single object tracking from GOTURN paper
MIT License
214 stars 67 forks source link

Implementation Error #14

Closed sydney0zq closed 6 years ago

sydney0zq commented 6 years ago

In example_generator.py module, there is a serious mistake which could make the whole program fail.

https://github.com/nrupatunga/PY-GOTURN/blob/79b6d6eae3c57b0a7a46883586182497e51faad2/goturn/helper/BoundingBox.py#L193

AND

https://github.com/nrupatunga/PY-GOTURN/blob/79b6d6eae3c57b0a7a46883586182497e51faad2/goturn/helper/BoundingBox.py#L213

The two lines uses wrong  brackets of logic gates. Please check it.

nrupatunga commented 6 years ago

Im checking this issue. I will let you know the update.

nrupatunga commented 6 years ago

This issue is fixed. Thank you @sydney0zq for pointing out the error. Updated as below:

https://github.com/nrupatunga/PY-GOTURN/blob/da303ad92603cb6457f56819579171dc6d22c2e9/goturn/helper/BoundingBox.py#L203

https://github.com/nrupatunga/PY-GOTURN/blob/da303ad92603cb6457f56819579171dc6d22c2e9/goturn/helper/BoundingBox.py#L223