nrupatunga / PY-GOTURN

This is the python-caffe implementation of single object tracking from GOTURN paper
MIT License
214 stars 67 forks source link

problem in goturn/train/train.py #8

Closed BigPuns closed 6 years ago

BigPuns commented 6 years ago

In function train_video, the param of tracker_trainer.train(image_prev, image_curr, bbox_prev, bbox_prev) is wrong? maybe the second bbox_prev is bbox_curr? In GOTURN C++ source code, here is( tracker_trainer->Train(image_prev, image_curr, bbox_prev, bbox_curr);

nrupatunga commented 6 years ago

For the first frame there is no previous available frame, so bbox_curr = bbox_prev.

BigPuns commented 6 years ago

The train_video function sets the frame 0 to (len(annotations) -1) is the prev frame, and frame 1 to len(annotations) is the curr frame. so bbox_curr and bbox_prev is exist. this is not correct, which is different from GOTURN C++ source code.

nrupatunga commented 6 years ago

Hi, thank you for noticing, I saw train_video had this bug. It should be fixed now