Add support for Capybara-Webkit 1.6.0

nruth / show_me_the_cookies

Cookie manipulation for Capybara (view, delete, …)

161 stars 44 forks source link

Add support for Capybara-Webkit 1.6.0 #32

Closed nritholtz closed 9 years ago

nritholtz commented 9 years ago

Due to recent changes in Capybara Webkit 1.6.0 and as mentioned in the latest NEWS:

Calling browser directly is deprecated
Calling the page.allow_url method is being deprecated in favor of a configuration block

nruth commented 9 years ago

Thanks for this. And sorry about the dog; I don't even remember installing that thing :)

Do you know if the changes will work on older versions of capybara-webkit or should I add a note / bump the version to indicate that?

I should really look into setting up testing against different gem versions.

nritholtz commented 9 years ago

The changes made for the browser deprecation should still work on older versions, however, the configuration block is definitely only 1.6.0+. So, I would add the bump to play it safe on all fronts.

Thanks.