nruth
commented
6 years ago Thanks for the contribution and sorry for the delay. I think I missed the email notification and don't usually look at the github navbar messages.
I'm fine with adding this, but it needs to run against the tests. Could you please add that? You'd need to:
- add the driver you are using as a dependency in the Gemfile (next to the other driver gems used for testing)
- duplicate the poltergeist spec file, rename it, and change the
:poltergeistsetup / driver selection parts in that new file to:phantomjs
Regarding supporting phantomjs drivers in general, they're sort-of deprecated (by me, and internet at large I would imagine) because of advances in selenium and headless chrome/firefox/etc. That said, I still use them for a few specs that haven't migrated cleanly yet, and I know it's not fun migrating legacy apps. Here it's really not a big deal because you're not adding code, just reusing the existing driver.
We had issues with new SSL versions while using :poltergeist driver. Switching to :phantomjs driver seemed to fix.
I don't pretend to know what's happening under the hood. It might have something to do with how we have it configured. So feel free to ignore this if it doesn't make sense.