nrwl / nx-cloud-workflows

MIT License
8 stars 6 forks source link

fix(install-browsers): install cypress if detected #31

Closed barbados-clemens closed 6 months ago

barbados-clemens commented 6 months ago

NOTE: playwright actually recommends not caching the binaries as it's just faster to download anyways? and in my testing it just redownloads anyways ignoring the previous cached version, while cypress skips installing. unsure how we feel about that?

https://staging.nx.app/cipes/65ca700e7009eb25221b7ae6?step=de63fbda-0a86-4c2c-a01e-de785ba403c6&instance=job-65ca700e7009eb25221b7ae8-agent-3#step-list-pane

WkMacM1-CHIGaWrJ_02121343

Second note: cache paths are from the workspace root i.e. ~/workspace, but binaries are installed at ~/.cache. This means we need to path up and over to the .cache directory.

Third note: what is the correct key here? ideally I could pass in the cypress/playwright version but can only use globs and hard coded values. for now it's the lock files + "browser" key.

barbados-clemens commented 6 months ago

will need someone with write permissions to merge this PR @rarmatei. WkMacM1-g991r55J_02121556