search

nrwl / nx-cloud-workflows

MIT License
8 stars 6 forks source link

checkout sha instead of PR specifics #34

Closed Cammisuli closed 5 months ago

Cammisuli commented 5 months ago

Current behaviour

When trying to use workflows in VSC environments that were not github, the checkout would fail because of github "PR" specifics. For example, gitlab would use "MR".

Expected behaviour

Checkouts now use only the NX_COMMIT_SHA which does not use any github PR specifics. This also simplifies the checkout code so that we don't have to check if we're pulling code from a main branch or a PR branch.

Cammisuli commented 5 months ago

I need to verify that this works properly with forks.