nrwl / nx-console

Nx Console is the user interface for Nx & Lerna.
https://nx.dev
MIT License
1.31k stars 213 forks source link

fix(vscode): retry nxls request if connection is disposed during request #2312

Closed MaxKless closed 2 weeks ago

MaxKless commented 2 weeks ago

Right now, if a request takes longer and users try to refresh the language server while the request is in flight (actually passed along to the language client, not just in our wrapper), an error will be thrown. This is potentially very ugly if run from a command and can be avoided. With our new state machine architecture, we can simply retry the request since it will automatically wait for the client to be running.

nx-cloud[bot] commented 2 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0fdf31d5698fbc405a7eb3562f7fb1a885f757f5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets - [`nx affected --targets=lint,test,build,e2e-ci --configuration=ci --exclude=nx-console --parallel=3`](https://staging.nx.app/runs/2e9wimoqS0?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- ./gradlew ktfmtCheck`](https://staging.nx.app/runs/4n73qRkPA9?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- npx nx format:check --verbose --skip-nx-cache`](https://staging.nx.app/runs/VmQonm9VaX?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- npx nx show projects --verbose`](https://staging.nx.app/runs/z8onUE0hlw?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- ./gradlew projectReportAll`](https://staging.nx.app/runs/WWwlsRMcXm?utm_source=pull-request&utm_medium=comment) - [`nx affected --targets=build,test,e2e-ci --configuration=ci --exclude=nx-console --parallel=3`](https://staging.nx.app/runs/k63nvZ08vX?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.