search

nrwl / nx-labs

A collection of Nx plugins
MIT License
144 stars 50 forks source link

feat(remix): add storybook-configuration generator #295

Closed Coly010 closed 1 year ago

Coly010 commented 1 year ago

Add a generator to create a storybook configuration for remix

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 961fcf294a5b46af56cef261562e74576bb2abc1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 4 targets - [`nx affected --target=e2e --parallel --max-parallel=1 --exclude=nx-ignore-e2e,gatsby-e2e`](https://cloud.nx.app/runs/IXO7vpjX6A) - [`nx affected --target=test --parallel --max-parallel=2`](https://cloud.nx.app/runs/sBtKZdn1lE) - [`nx affected --target=build --parallel --max-parallel=3`](https://cloud.nx.app/runs/6GMSvszjO7) - [`nx affected --target=lint --parallel --max-parallel=3`](https://cloud.nx.app/runs/uNKOIWpHxV)

Sent with 💌 from NxCloud.

philipjfulcher commented 1 year ago

Code looks good, but I'd like to take some time to test.

Coly010 commented 1 year ago

@philipjfulcher please do! There’s bound to be some kind of edge case I’ve missed. I tested it out with a component Chau directed me to in Ocean.

there is 1 caveat. There was a bug in the Nx/storybook configuration generator where it wasn’t adding the path to the viteConfig in the main.js of storybook automatically. Katerina merged a fix for that yesterday, but until a new patch is released, you’ll need to set that manually.