search

nrwl / nx-labs

A collection of Nx plugins
MIT License
144 stars 50 forks source link

feat(deno): allow test to succeed if there are no tests to run #305

Closed charsleysa closed 1 year ago

charsleysa commented 1 year ago

@barbados-clemens I've updated the PR according to your feedback.

I have added allowNone as an option. I have not made it default to true inside the executor in order to keep the functionality the same for existing projects. I have added the option to the generators so that new projects are generated with allowNone set to true.

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 36dc4afbba088754e8c5cd1519e40a4b91232d47. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 4 targets - [`nx affected --target=e2e --parallel --max-parallel=1 --exclude=nx-ignore-e2e,gatsby-e2e`](https://cloud.nx.app/runs/oHEW0MITVZ) - [`nx affected --target=test --parallel --max-parallel=2`](https://cloud.nx.app/runs/XzDsQHRY6e) - [`nx affected --target=build --parallel --max-parallel=3`](https://cloud.nx.app/runs/Hlhw3VjsQ2) - [`nx affected --target=lint --parallel --max-parallel=3`](https://cloud.nx.app/runs/DDMihN3unK)

Sent with 💌 from NxCloud.

charsleysa commented 1 year ago

@barbados-clemens thanks for the feedback! Looks like I misunderstood how the default field in the schema functioned. I've made the changes as recommended.