nrwl / nx-labs

A collection of Nx plugins
MIT License
144 stars 50 forks source link

fix(remix): set up e2e so it runs out of the box #313

Closed jaysoo closed 1 year ago

jaysoo commented 1 year ago

When generating the remix app, the e2e tests don't work unless the use pass in specific options. It is not a good experience for users.

The Cypress executor needs the executor in devServerTarget to emit a value (e.g. {success: true, baseUrl: 'http://localhost:3000}, but run-commands don't do this. Thus we need to start the dev server in another dependency task, and pass skipServe to Cypress.

After this PR, user can do this:

nx g @nx/remix: app demo
nx e2e demo-e2e
nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 03848b25dbba29d92dea7ff759c7df8ba2cfc89c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets - [`nx affected --target=e2e --parallel --max-parallel=1 --exclude=nx-ignore-e2e,gatsby-e2e`](https://cloud.nx.app/runs/fmpA2e4Sd3) - [`nx affected --target=test --parallel --max-parallel=2`](https://cloud.nx.app/runs/97OldGypsL) - [`nx affected --target=build --parallel --max-parallel=3`](https://cloud.nx.app/runs/w1G3YjoLXv) - [`nx affected --target=lint --parallel --max-parallel=3`](https://cloud.nx.app/runs/jPSplNHfA8)

Sent with 💌 from NxCloud.