nrwl / nx-labs

A collection of Nx plugins
MIT License
144 stars 50 forks source link

Upgrading nx/remix to run remix 2.1.0 #343

Closed 127 closed 11 months ago

127 commented 1 year ago

What about upgrading @nx/remix to support 2.1.0 (2.2.0)? Any plans?

127 commented 1 year ago

remix 2.2.0 support vite since yesterday https://github.com/remix-run/remix/releases/tag/remix%402.2.0

travtarr commented 1 year ago

Hopefully this can open up Remix to be an official plugin since I believe the only thing holding it back before was a way to get access to the compiler (which Remix's Vite plugin should allow) for a more seamless integration with Nx.

I imagine this will be fairly straightforward as it will allow us to just re-use the @nx/vite package's executors.

underfisk commented 1 year ago

I'm also looking forward having remix v2 support with vite (as an opt in)

Mat-moran commented 1 year ago

Me too, I am also waiting for this to be came up! 😄 It is incredible the development experience with the new Vite support you can check it here https://www.youtube.com/watch?v=B_vIp4xETl4 and how to migrate an actual remix app here https://www.youtube.com/watch?v=g60FI9Oyfs4

Mat-moran commented 12 months ago

remix v2 is comming ❄️ https://github.com/nrwl/nx-labs/pull/350

johannesschobel commented 11 months ago

I think this issue can be closed @127

kosiakMD commented 9 months ago

@johannesschobel why it's closed? what is the solution for nx + remix v2+?

johannesschobel commented 9 months ago

@kosiakMD : i think the latest version of @nx/remix uses remix v.2.x under the hood. You may need to check the package.json file in your mono-repository.

All the best

nadiTime commented 8 months ago

Trying to update remix in nx to use vite but getting this error when running dev server

image

when im removing the nx/vite pluging from nx.json it works,

I guess its because the plugin is detecting the vite.config file inside the remix app nx/vite

trying to run nx show project my-project --web gives the same error, so no help there... any ideas how to solve this without removing the plugin?

binaryartifex commented 7 months ago

latest nx remix generator isn't using vite and im getting the same errors as @nadiTime when i try to manually include it