search

nrwl / nx-labs

A collection of Nx plugins
MIT License
140 stars 51 forks source link

feat: upgrade rspack to 0.4.4 #352

Closed ahabhgk closed 9 months ago

ahabhgk commented 10 months ago

upgrade Rspack to 0.4.4, https://www.rspack.dev/blog/announcing-0.4.html#rspack-04-major-changes

This contains break change since experiments.rspackFuture.disableTransformByDefault is enabled by default in Rspack 0.4

nx-cloud[bot] commented 10 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 32c9a00ee407fcf6e937006d0a6d849898b832b6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx affected --target=e2e --parallel --max-parallel=1 --exclude=nx-ignore-e2e,gatsby-e2e
✅ Successfully ran 3 targets - [`nx affected --target=test --parallel --max-parallel=2`](https://cloud.nx.app/runs/3XPrQb3JA7) - [`nx affected --target=build --parallel --max-parallel=3`](https://cloud.nx.app/runs/RlmQ8HR094) - [`nx affected --target=lint --parallel --max-parallel=3`](https://cloud.nx.app/runs/Bu9pERiht8)

Sent with 💌 from NxCloud.

ahabhgk commented 10 months ago

FAIL rspack-e2e e2e/rspack-e2e/tests/rspack.spec.ts (94.123 s), seems e2e of the generated project (tmp/nx-e2e/proj) are failed, but it passes when I run yarn run e2e under tmp/nx-e2e/proj

jaysoo commented 9 months ago

It looks like ReactRefresh is being used in non-dev builds too, so it's causing Cypress test to fail due to React's warning against it in production mode.

jaysoo commented 9 months ago

It also looks like Nest is failing the e2e test. It cannot compile the decorator in app.module.ts.

I see something like this:


> nx run app3456491:build:production

PublicPath: /
asset assets/.gitkeep 0 bytes [emitted]
asset main.js 9.73 KiB [emitted] (name: main)
Entrypoint main 9.73 KiB = main.js
runtime modules 9 modules
./app3456491/src/main.ts
external ["@nestjs/core"]
external ["@nestjs/common"]
./app3456491/src/app/app.module.ts
  × Error[javascript]: JavaScript parsing error
   ╭─[app3456491/src/app/app.module.ts:5:1]
 5 │
 6 │ @Module({
   · ┬
   · ╰── Expression expected
 7 │   imports: [],
   ╰────

Rspack 0.4.3 compiled with 1 error in 35 ms (befe8ffbdb5228c52c4b)
ahabhgk commented 9 months ago

Thanks for your help! There is still a bug on Rspack side which breaks license-webpack-plugin, will ship the fix in 0.4.4, I will update the PR when it is released

nx-cloud[bot] commented 9 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c974ef2dbdd83359cc002b7120838444f4dd8280. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets - [`nx affected --target=e2e --parallel --max-parallel=1 --exclude=nx-ignore-e2e,gatsby-e2e`](https://cloud.nx.app/runs/oMNZNFJgCE?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel --max-parallel=2`](https://cloud.nx.app/runs/Vle50sb52e?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=build --parallel --max-parallel=3`](https://cloud.nx.app/runs/zkE5kKwQY4?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel --max-parallel=3`](https://cloud.nx.app/runs/pDYDI4EAy8?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

ahabhgk commented 9 months ago

Ready for review!