search

nrwl / nx-labs

A collection of Nx plugins
MIT License
130 stars 48 forks source link

fix(rspack): do not depend directly on ajv to allow for correct hoisting #384

Closed Coly010 closed 3 months ago

Coly010 commented 3 months ago

We currently depend on ajv and ajv-keywords directly in @nx/rspack which creates incorrect hositing pattern for package managers.

Allow hoisting to occur correctly by not depending directly on these packages. They are defined within @rspack/dev-server -> webpack-dev-server-middleware already.

nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 79e6e7a313b3fab840adb103071c4be936ded2b0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets - [`nx affected --target=e2e --parallel --max-parallel=1 --exclude=nx-ignore-e2e`](https://cloud.nx.app/runs/qW2van2tRq?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel --max-parallel=2`](https://cloud.nx.app/runs/qMlxP6H5cD?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=build --parallel --max-parallel=3`](https://cloud.nx.app/runs/XHnf4vRjdB?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel --max-parallel=3`](https://cloud.nx.app/runs/u6Jai7q4lt?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.