search

nrwl / nx-set-shas

:sparkles: A Github Action which sets the base and head SHAs required for `nx affected` commands in CI
https://nx.dev
MIT License
162 stars 76 forks source link

Enclose arguments in quotes to ensure position #105

Closed devholic closed 1 year ago

devholic commented 1 year ago

In the current implementation, passing a blank value as input may result in unexpected behavior because the arguments are not guaranteed to exist in the specific position. (For example, we can pass empty value to last-successful-event for fetching all type of events.)

This commit fixes this issue by enclosing arguments in quotes to ensure that all provided arguments are passed correctly.

meeroslav commented 1 year ago

This should be fixed with https://github.com/nrwl/nx-set-shas/pull/98. Sorry and thank you for the effort!