nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.63k stars 2.36k forks source link

ci cd pipeline gets tripped up with scratch folders with yml files #11087

Closed nhhockeyplayer closed 1 year ago

nhhockeyplayer commented 2 years ago

SUBJECT: ci cd pipeline gets tripped up with scratch folders with yml files

Current Behavior

Nx cloud works great

As a developer I tend to prototype and have some extra baggage like a 'proto' folder at root of my project with various config build files to draw off of

But Nx is interrogating them during the CI/CD ci.yml processing and its causing false positives

Expected Behavior

Nx should friendly ignore these

I added my folder to .gitignore but that made no difference on PR

nx.json, angular.json and tsconfig.base.json also produce false positive format checks this was worked around by adding them to .gitignore

Steps to Reproduce

create scratch folder

add yml files with format errors

launch a CI/CD ci.yml build for that project

Failure Logs

NxCloud detects the failures to the cmd level

but we have to run them locally to actually see whats failing

Environment

nx report

 >  NX   Report complete - copy this into the issue template

   Node : 16.15.1
   OS   : darwin x64
   yarn : 1.22.18

   nx : 14.4.2
   @nrwl/angular : 14.4.2
   @nrwl/cypress : 14.4.2
   @nrwl/detox : Not Found
   @nrwl/devkit : 14.4.2
   @nrwl/eslint-plugin-nx : 14.4.2
   @nrwl/express : 14.4.2
   @nrwl/jest : 14.4.2
   @nrwl/js : 14.4.2
   @nrwl/linter : 14.4.2
   @nrwl/nest : 14.4.2
   @nrwl/next : Not Found
   @nrwl/node : 14.4.2
   @nrwl/nx-cloud : 14.2.0
   @nrwl/nx-plugin : Not Found
   @nrwl/react : Not Found
   @nrwl/react-native : Not Found
   @nrwl/schematics : 8.12.11
   @nrwl/storybook : 14.4.2
   @nrwl/web : 14.4.2
   @nrwl/workspace : 14.4.2
   typescript : 4.7.4
   ---------------------------------------
   Community plugins:
     @fortawesome/angular-fontawesome: 0.11.1
     @ionic/angular: 6.1.13
     @ngrx/component: 14.0.1
     @ngrx/component-store: 14.0.1
     @ngrx/effects: 14.0.1
     @ngrx/entity: 14.0.1
     @ngrx/router-store: 14.0.1
     @ngrx/store: 14.0.1
     @nxtend/capacitor: 13.0.0
     @nxtend/ionic-angular: 13.1.0
     @storybook/angular: 6.5.9
     angular-builder-custom-terser-options: 1.0.1
     @compodoc/compodoc: 1.1.19
     @ngrx/schematics: 14.0.1
     @ngrx/store-devtools: 14.0.1
     @nxtend/capacitor: 13.0.0
     @storybook/angular: 6.5.9
nhhockeyplayer commented 2 years ago

this minor bug (if it is) can be mitigated with yml paths-ignore: yml file property still shaking this out

But I continue to find pnpm in my log files... can anyone acknowledge this is officially being integrated?

I continue to get failures seeing pnpm in the logs can anyone answer... is pnpm being integrated to Nx? Is this a silent quiet attempt? my failure logs sghow its in there being used Run echo "::set-output name=name::$([[ -f ./yarn.lock ]] && echo "yarn" || ([[ -f ./pnpm-lock.yaml ]] && echo "pnpm") || echo "npm")"

my builds re tracked at NxCloud https://nx.app/orgs/5fb26f98217e0a00056ed9ec/workspaces/62c5ad1a5d8e7846bfcb76e5/runs

so Im still shaking out failures trying to get a settled workspace

is this a valid path? VOLTA_HOME: /opt/hostedtoolcache/volta/1.0.8/x64 do we need to install https://github.com/dotenv-org/dotenv-vault as part of our projects?

trying to shake out NxCloud build

any help is appreciated

feel free to tap in to my repo just ask to be collab https://github.com/nhhockeyplayer/meanstacknh

I would like to put build issues behind me and go back into my business logic

2s
Run if [ "true" == "true" ]; then
  if [ "true" == "true" ]; then
    echo "Running yarn install --frozen-lockfile"
    yarn install --frozen-lockfile
  elif [ "false" == "true" ]; then
    echo "Running pnpm install --frozen-lockfile"
    pnpm install --frozen-lockfile
  else
    echo "Running npm ci"
    npm ci
  fi
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    NX_CLOUD_DISTRIBUTED_EXECUTION: true
    NX_CLOUD_DISTRIBUTED_EXECUTION_AGENT_COUNT: 3
    NX_BRANCH: main
    NX_CLOUD_ACCESS_TOKEN: 
    NX_CLOUD_AUTH_TOKEN: 
    NX_BASE: a45deaa0[1](https://github.com/nhhockeyplayer/meanstacknh/runs/7264715538?check_suite_focus=true#step:15:1)76c736ed[2](https://github.com/nhhockeyplayer/meanstacknh/runs/7264715538?check_suite_focus=true#step:15:2)[3](https://github.com/nhhockeyplayer/meanstacknh/runs/7264715538?check_suite_focus=true#step:15:3)5c[4](https://github.com/nhhockeyplayer/meanstacknh/runs/7264715538?check_suite_focus=true#step:15:4)27864[5](https://github.com/nhhockeyplayer/meanstacknh/runs/7264715538?check_suite_focus=true#step:15:5)b95f4d31b498
    NX_HEAD: e821f0d5d54[6](https://github.com/nhhockeyplayer/meanstacknh/runs/7264715538?check_suite_focus=true#step:15:6)c5bdcc26614[7](https://github.com/nhhockeyplayer/meanstacknh/runs/7264715538?check_suite_focus=true#step:15:7)da3[8](https://github.com/nhhockeyplayer/meanstacknh/runs/7264715538?check_suite_focus=true#step:15:8)10b8585156e7
    VOLTA_HOME: /opt/hostedtoolcache/volta/1.0.8/x64
Running yarn install --frozen-lockfile
yarn install v1.22.1[9](https://github.com/nhhockeyplayer/meanstacknh/runs/7264715538?check_suite_focus=true#step:15:9)
warning package.json: "dependencies" has dependency "@storybook/angular" with range "^6.5.9" that collides with a dependency in "devDependencies" of the same name with version "6.5.9"
warning package.json: "dependencies" has dependency "@storybook/core-server" with range "^6.5.9" that collides with a dependency in "devDependencies" of the same name with version "6.5.9"
warning package.json: "dependencies" has dependency "@types/passport-local" with range "^1.0.34" that collides with a dependency in "devDependencies" of the same name with version "^1.0.33"
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.