search

nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
22.72k stars 2.27k forks source link

[Feature Request] Support new @angular/cli v8 builder architecture #1226

Closed Domratchev closed 5 years ago

Domratchev commented 5 years ago

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

Expected Behavior

Nx builders to work with Angular CLI v8

Current Behavior

Nx builders are incompatible with @angular-devkit/architect@0.800.0.beta-11

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Install latest Angular CLI beta.
  2. Run ng test
  3. Observe Could not find the implementation for builder @nrwl/builders:jest error

Context

Please provide any relevant information about your setup:

Other

A brute-force approach of changing builders.json to include "implementation": "./jest/jest.builder" property does not work. It results in another error: Builder is not a builder. The builders are completely redone in the new Angular CLI architecture.

Here is the documentation for new Architect API: https://docs.google.com/document/d/1SpN_2XEooI9_CPjqspAcNEBjVY874OWPZqOenjuF0qo/view

Domratchev commented 5 years ago

https://github.com/angular/angular-cli/pull/13994

FrozenPandaz commented 5 years ago

I've begun working on converting the builders over to the new API (aka, I have Cypress done). For now, hold off on upgrading to @angular/cli@8.0.0.

GrandSchtroumpf commented 5 years ago

I just upgraded my nwrl repo, and I still have the problem :

Domratchev commented 5 years ago

@GrandSchtroumpf Nrwl package structure is different now. You need to use @nrwl/jest:jest there. Here are the details: https://github.com/nrwl/nx/blob/master/docs/guides/nx7-to-nx8.md

GrandSchtroumpf commented 5 years ago

Oh ok great, thx.

sajidali commented 5 years ago

@Domratchev reading the guide nx7-to-nx8 helped me solve all the issues I was having. Thank you.

vsavkin commented 5 years ago

Closing this as we migrated all existing builders to the new API.

killface commented 5 years ago

For anyone upset that the above link doesn't work, it's now here: https://nx.dev/angular/guides/nx7-to-nx8

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.