search

nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.62k stars 2.36k forks source link

Migration update-15-7-0 prints a broken link #14983

Closed e-oz closed 1 year ago

e-oz commented 1 year ago

Current Behavior

It's a super-tiny and not so important thing, but maybe because I had no stories to remove from a global file and migration went smoothly for the project I've updated today ;)

Read more about our effort to deprecate the root .storybook folder here:
    https://nx.dev/packages/storybook/configuring-storybook

404 with a funny cat.

Expected Behavior

Some documentation without a hanging cat.

GitHub Repo

No response

Steps to Reproduce

  1. nx migrate latest
  2. yarn nx migrate --run-migrations

Nx Report

Node : 19.4.0
   OS   : darwin arm64
   yarn : 1.22.17

   nx                      : 15.7.0
   @nrwl/jest              : 15.7.0
   @nrwl/linter            : 15.7.0
   @nrwl/workspace         : 15.7.0
   @nrwl/angular           : 15.7.0
   @nrwl/cli               : 15.7.0
   @nrwl/cypress           : 15.7.0
   @nrwl/devkit            : 15.7.0
   @nrwl/eslint-plugin-nx  : 15.7.0
   @nrwl/js                : 15.7.0
   @nrwl/storybook         : 15.7.0
   @nrwl/tao               : 15.7.0
   @nrwl/webpack           : 15.7.0
   @nrwl/nx-cloud          : 15.0.3
   typescript              : 4.9.5
   ---------------------------------------
   Community plugins:
   @ng-bootstrap/ng-bootstrap : 14.0.1
   @ngrx/component-store      : 15.3.0
   @ngrx/data                 : 15.3.0
   @ngrx/effects              : 15.3.0
   @ngrx/entity               : 15.3.0
   @ngrx/store                : 15.3.0
   @ngrx/store-devtools       : 15.3.0
   @rx-angular/cdk            : 1.0.0
   @rx-angular/template       : 1.0.0
   ngx-bootstrap              : 10.2.1
   @jefiozie/ngx-aws-deploy   : 5.0.0
   @storybook/angular         : 7.0.0-beta.47
   @testing-library/angular   : 13.1.0
   ng-mocks                   : 14.6.0

Failure Logs

No response

Additional Information

No response

TomONeill commented 1 year ago

What's the correct link?

Flusinerd commented 1 year ago

Seems like the correct URL should be https://nx.dev/packages/storybook/documents/configuring-storybook

Flusinerd commented 1 year ago

https://github.com/nrwl/nx/blob/master/packages/storybook/src/migrations/update-15-7-0/add-addon-essentials-to-all.ts#L82

This should be the correct line to change. I think we should also take a look at older migrations for the same broken url What do you think?

e-oz commented 1 year ago

What do you think?

Me? I think you are awesome developers and can figure out what to do, I'm not in position to decide here ;)

Thanks for fixing it!

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.