`@nrwl/webpack` included on `generatePackageJson: true`

DerHerrGammler commented 1 year ago

Current Behavior

Currently the generatePackageJson flag generates the @nrwl/webpack package as dependecies in the build package.json.

Expected Behavior

This package should not included in the final package.json. It is just needed for the build process.
It should be ignored or we need something like a excludeDependencies = [] option to disable specific packages from the build package.json

GitHub Repo

No response

Steps to Reproduce

Generate a simple express app
Add generatePackageJson flag to project.json
Build the app
package.json includes @nrwl/webpack

Nx Report

Node : 18.14.2
   OS   : win32 x64
   npm  : 9.5.0

   nx : 15.6.3
   @nrwl/angular : 15.6.3
   @nrwl/cypress : 15.6.3
   @nrwl/detox : Not Found
   @nrwl/devkit : 15.6.3
   @nrwl/esbuild : Not Found
   @nrwl/eslint-plugin-nx : 15.6.3
   @nrwl/expo : Not Found
   @nrwl/express : 15.6.3
   @nrwl/jest : 15.6.3
   @nrwl/js : 15.6.3
   @nrwl/linter : 15.6.3
   @nrwl/nest : 15.6.3
   @nrwl/next : Not Found
   @nrwl/node : 15.6.3
   @nrwl/nx-cloud : Not Found
   @nrwl/nx-plugin : Not Found
   @nrwl/react : Not Found
   @nrwl/react-native : Not Found
   @nrwl/rollup : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : Not Found
   @nrwl/web : Not Found
   @nrwl/webpack : 15.6.3
   @nrwl/workspace : 15.6.3
   @nrwl/vite : Not Found
   typescript : 4.9.5
   ---------------------------------------
   Local workspace plugins:
   ---------------------------------------
   Community plugins:
         @nx-plus/docusaurus: 15.0.0-rc.0

Failure Logs

No response

Additional Information

No response

AgentEnder commented 1 year ago

@nrwl/webpack should be in devDependencies, which would exclude it.

DerHerrGammler commented 1 year ago

It is in the devDependeincies. Here are my complete dependencies:

{
    "dependencies": {
        "@angular/animations": "15.2.0",
        "@angular/cdk": "15.2.0",
        "@angular/common": "15.2.0",
        "@angular/compiler": "15.2.0",
        "@angular/core": "15.2.0",
        "@angular/forms": "15.2.0",
        "@angular/material": "15.2.0",
        "@angular/platform-browser": "15.2.0",
        "@angular/platform-browser-dynamic": "15.2.0",
        "@angular/router": "15.2.0",
        "@docusaurus/core": "2.3.1",
        "@docusaurus/preset-classic": "2.3.1",
        "@easyops-cn/docusaurus-search-local": "0.34.0",
        "@mdi/svg": "7.1.96",
        "@mdx-js/react": "1.6.22",
        "@nestjs/common": "9.3.7",
        "@nestjs/core": "9.3.7",
        "@nestjs/platform-express": "9.3.7",
        "@ng-matero/extensions": "15.1.0",
        "axios": "1.3.3",
        "better-sqlite3": "8.1.0",
        "bootstrap": "5.2.3",
        "clsx": "1.2.1",
        "cors": "2.8.5",
        "express": "4.18.2",
        "flag-icons": "6.6.6",
        "got": "11.8.6",
        "helmet": "6.0.1",
        "http-status-codes": "2.2.0",
        "node-cron": "3.0.2",
        "nodemailer": "6.9.1",
        "plugin-image-zoom": "github:flexanalytics/plugin-image-zoom",
        "prism-react-renderer": "1.3.5",
        "react": "17.0.2",
        "react-dom": "17.0.2",
        "rxjs": "7.8.0",
        "simple-icons": "8.6.0",
        "striptags": "3.2.0",
        "swagger-ui-express": "4.6.2",
        "tslib": "2.5.0",
        "typeorm": "0.3.12",
        "typescript-json-schema": "0.55.0",
        "zone.js": "0.12.0"
    },
    "devDependencies": {
        "@angular-devkit/build-angular": "15.2.0",
        "@angular-eslint/eslint-plugin": "15.2.1",
        "@angular-eslint/eslint-plugin-template": "15.2.1",
        "@angular-eslint/template-parser": "15.2.1",
        "@angular/cli": "15.2.0",
        "@angular/compiler-cli": "15.2.0",
        "@angular/language-service": "15.2.0",
        "@docusaurus/module-type-aliases": "2.3.1",
        "@gitbeaker/node": "35.8.0",
        "@html-eslint/eslint-plugin": "0.16.0",
        "@html-eslint/parser": "0.16.0",
        "@nestjs/schematics": "9.0.4",
        "@nestjs/testing": "9.3.7",
        "@nrwl/angular": "15.6.3",
        "@nrwl/cli": "15.6.3",
        "@nrwl/cypress": "15.6.3",
        "@nrwl/eslint-plugin-nx": "15.6.3",
        "@nrwl/express": "15.6.3",
        "@nrwl/jest": "15.6.3",
        "@nrwl/js": "15.6.3",
        "@nrwl/linter": "15.6.3",
        "@nrwl/nest": "15.6.3",
        "@nrwl/node": "15.6.3",
        "@nrwl/workspace": "15.6.3",
        "@nx-plus/docusaurus": "15.0.0-rc.0",
        "@typescript-eslint/eslint-plugin": "5.54.0",
        "@typescript-eslint/parser": "5.54.0",
        "cypress": "12.7.0",
        "dotenv": "16.0.3",
        "eslint": "8.35.0",
        "eslint-config-prettier": "8.6.0",
        "eslint-plugin-cypress": "2.12.1",
        "eslint-plugin-html": "7.1.0",
        "eslint-plugin-rxjs": "5.0.2",
        "eslint-plugin-rxjs-angular": "2.0.0",
        "eslint-plugin-security": "1.7.1",
        "eslint-plugin-unicorn": "45.0.2",
        "husky": "8.0.3",
        "ignore": "5.2.4",
        "jest": "29.4.3",
        "jest-canvas-mock": "2.4.0",
        "jest-dev-server": "7.0.1",
        "jest-environment-jsdom": "29.4.3",
        "jest-preset-angular": "13.0.0",
        "jest-sonar-reporter": "2.0.0",
        "ng-packagr": "15.2.2",
        "nx": "15.6.3",
        "open-cli": "7.1.0",
        "postcss": "8.4.21",
        "postcss-import": "15.1.0",
        "postcss-preset-env": "8.0.1",
        "postcss-url": "10.1.3",
        "prettier": "2.8.4",
        "ts-jest": "29.0.5",
        "ts-node": "10.9.1",
        "typescript": "4.9.5",
        "webpack-bundle-analyzer": "4.8.0"
    },
    "optionalDependencies": {
        "@types/cors": "2.8.13",
        "@types/express": "4.17.17",
        "@types/jest": "29.4.0",
        "@types/jest-dev-server": "5.0.0",
        "@types/node": "18.14.2",
        "@types/node-cron": "3.0.7",
        "@types/nodemailer": "6.4.7",
        "@types/swagger-ui-express": "4.1.3"
    },
}

As you see the package @nrwl/webpack is in the devDependencies but it end in the normal dependencies in the generated package.json

DerHerrGammler commented 1 year ago

Ok seems to be fixed now with the changs according to the generatePackageJson in v15.8.1. after updating to it the @nrwl/webpack is no longer generated to the package.json

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

nrwl / nx