nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
22.72k stars 2.27k forks source link

Wiki section on "How to set default options for a specific schematic?" is outdated for nx8 #1653

Closed virtuoushub closed 4 years ago

virtuoushub commented 4 years ago

The following does not work for nx8.

// angular.json
"schematics": {
  "@nrwl/schematics:component": {
    "styleext": "scss"
  }
},

Source: https://github.com/nrwl/nx/wiki/FAQ#how-to-set-default-options-for-a-specific-schematic

Adding a subsection for nx8 that looks like the below might help those coming to that wiki using nx8

// angular.json(nx8)
"schematics": {
  "@nrwl/angular:component": {
    "styleext": "scss"
  }
},

relates to #158 #533 See also: https://github.com/nrwl/nx/blob/ccd5854a981df28ba38f2013e3ebbb87057650b7/docs/angular/guides/nx7-to-nx8.md#schematics

mehrad-rafigh commented 4 years ago

Good catch @virtuoushub! I tried to update the wiki, but I can not push to master. Did not find any contribution guideline for the wiki sites. Asked @bcabanes, but I have that fixed that. See diff below

index 0f66572..3442d6b 100644
--- a/FAQ.md
+++ b/FAQ.md
@@ -30,7 +30,7 @@ Will update the `angular.json` of your project like this:
 ```javascript
 // angular.json
 "schematics": {
-  "@nrwl/schematics:component": {
+  "@nrwl/angular:component": {
     "styleext": "scss"
   }
 },

We need to update a few commands on the other wiki pages as well, like https://github.com/nrwl/nx/wiki/Nx-and-Angular-CLI

FrozenPandaz commented 4 years ago

Good catch! I just updated the guide. :tada:

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.