Angular Language Service extension broken after upgrade to 16.3.2

abf7d commented 1 year ago

Current Behavior

I am running an Angular project. After I upgraded Nx to version 16.3.2 all of my component templates have errors. I get the following error when I open VS Code:

Angular extension might not work correctly because ngcc operation failed. Try to invoke ngcc manually by running 'npm/yarn run ngcc'. Please see the extension output for more information.

Angular Language Service extension

I don't know if this is due to updates of dependencies, but I wanted to ask if you have any ideas or know where to look.

Expected Behavior

I expect no errors in the angular templates and for the Angular Language Service extension to work properly.

GitHub Repo

https://github.com/abf7d/critical-pass

Steps to Reproduce

Clone the repository and pull down the branch v16-upgrade-electron-2-list

Nx Report

nx                 : 16.3.2
   @nx/js             : 16.3.2
   @nx/jest           : 16.3.2
   @nx/linter         : 16.3.2
   @nx/workspace      : 16.3.2
   @nx/angular        : 16.3.2
   @nx/cypress        : 16.3.2
   @nx/devkit         : 16.3.2
   @nx/eslint-plugin  : 16.3.2
   @nrwl/tao          : 16.3.2
   @nx/web            : 16.3.2
   @nx/webpack        : 16.3.2
   nx-cloud           : 16.0.5
   typescript         : 5.0.4
   ---------------------------------------
   Community plugins:
   nx-electron : 16.0.0-beta.1

Failure Logs

Angular extension might not work correctly because ngcc operation failed. Try to invoke ngcc manually by running 'npm/yarn run ngcc'. Please see the extension output for more information.

Angular Language Service extension

Package Manager Version

No response

Operating System

[ ] macOS
[ ] Linux
[X] Windows
[ ] Other (Please specify)

Additional Information

No response

rlmestre commented 1 year ago

ngcc was removed in Angular 16 and nx-electron@16.0.0-beta.1 has Angular 15 dependencies. There might be some conflicts there. That package is also not fully compatible with Nx 16 yet (see bennymeg/nx-electron#217)

leosvelperez commented 1 year ago

Thanks for reporting this!

As mentioned by @rlmestre, ngcc is no longer available in Angular 16. If you are using anything that relies on it, you can't update to Angular 16. This is not an issue caused by Nx or Angular. It's just a constraint from the Angular v16 release.

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

nrwl / nx