nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.56k stars 2.36k forks source link

[Cypress] allow passing --ci-build-id option to e2e command #2068

Closed jon301 closed 4 years ago

jon301 commented 4 years ago

Expected Behavior

--ci-build-id should be a valid option

https://docs.cypress.io/guides/guides/command-line.html#cypress-run-ci-build-id-lt-id-gt

Current Behavior

ng e2e --headless --record --parallel --ci-build-id="XXX"

Unknown option: '--ci-build-id'

Failure Logs

On some Github Action CI, cypress does not recognize ciBuildId automatically, so this option needs to be passed manually.

$ ng e2e --configuration=ci --base-url=http://localhost:4200 --headless --record --parallel
It looks like this is your first time using Cypress: 3.4.0

25l[13:41:51]  Verifying Cypress can run /home/runner/.cache/Cypress/3.4.0/Cypress [started]
[13:41:57]  Verified Cypress!       /home/runner/.cache/Cypress/3.4.0/Cypress [title changed]
[13:41:57]  Verified Cypress!       /home/runner/.cache/Cypress/3.4.0/Cypress [completed]
25h
Opening Cypress...
You passed the --group or --parallel flag but we could not automatically determine or generate a ciBuildId.

The --parallel flag you passed was: true

In order to use either of these features a ciBuildId must be determined.

The ciBuildId is automatically detected if you are running Cypress in any of the these CI providers:

- appveyor
- azure
- bamboo
- bitbucket
- buildkite
- circle
- codeshipBasic
- codeshipPro
- concourse
- drone
- gitlab
- goCD
- googleCloud
- jenkins
- semaphore
- shippable
- teamfoundation
- travis

Because the ciBuildId could not be auto-detected you must pass the --ci-build-id flag manually.
jon301 commented 4 years ago

Closing since Cypress will support Github Actions build ID natively in the next release

https://github.com/cypress-io/cypress/commit/95a5d17fa0a6fbf5660697fab709024622cf37b9

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.