search

nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.57k stars 2.36k forks source link

Option "isolatedConfig" is deprecated: #20738

Open ojemuyiwa opened 10 months ago

ojemuyiwa commented 10 months ago

Documentation issue

Is there a specific documentation page you are reporting?

Enter the URL or documentation section here.

Additional context or description

WARNING: Option "isolatedConfig" is deprecated: Automatic configuration of Webpack is deprecated in favor of an explicit 'webpack.config.js' file. This option will be removed in Nx 18. See https://nx.dev/recipes/webpack/webpack-config-setup.

but isolatedConfig has been removed from my package.json and warning still shows?

"options": {
        "compiler": "babel",
        "outputPath": "dist/ui/browser",
        "index": "src/index.html",
        "baseHref": "/ui/",
        "main": "src/main.tsx",
        "tsConfig": "tsconfig.app.json",
        "assets": ["src/favicon.ico", "src/assets"],
        "styles": ["src/styles.css"],
        "scripts": [],
        "webpackConfig": "./webpack.config.js"
      },
jaysoo commented 10 months ago

Which version of Nx are you on? Can you run nx report and paste the info here?

ojemuyiwa commented 10 months ago

Which version of Nx are you on? Can you run nx report and paste the info here?

17.2.0

jaysoo commented 10 months ago

can you try the latest patch 17.2.4?

ojemuyiwa commented 10 months ago

can you try the latest patch 17.2.4?

Ok will do on the morrow, cheers

ojemuyiwa commented 10 months ago

17.2.4

17.2.3 is latest and new migration caused even more issues

Screenshot 2023-12-14 at 10 00 54
ojemuyiwa commented 10 months ago

used 17.2.4 explicitly and still broken, no liveReload on SSR so i guess I'll remove it and give feedback.

Screenshot 2023-12-14 at 10 04 12
jaysoo commented 10 months ago

Can you provide a small reproduction for this issue? It will help with the investigation.

beeman commented 10 months ago

Can you provide a small reproduction for this issue? It will help with the investigation.

image

I'm seeing the same in this project - maybe that helps to debug it? 

 >  NX   Report complete - copy this into the issue template

   Node   : 20.9.0
   OS     : darwin-arm64
   pnpm   : 8.9.2

   nx                 : 17.2.8
   @nx/js             : 17.2.8
   @nx/jest           : 17.2.8
   @nx/linter         : 17.2.8
   @nx/eslint         : 17.2.8
   @nx/workspace      : 17.2.8
   @nx/cypress        : 17.2.8
   @nx/devkit         : 17.2.8
   @nx/eslint-plugin  : 17.2.8
   @nx/nest           : 17.2.8
   @nx/node           : 17.2.8
   @nx/plugin         : 17.2.8
   @nx/react          : 17.2.8
   @nx/rollup         : 17.2.8
   @nrwl/tao          : 17.2.8
   @nx/web            : 17.2.8
   @nx/webpack        : 17.2.8
   typescript         : 5.3.3
   ---------------------------------------
   Community plugins:
   @pubkey-ui/generators            : 1.1.0
   @solana-developers/preset-anchor : 2.0.0
   ---------------------------------------
   Local workspace plugins:
         @pubkey-stack/tools
gRoussac commented 10 months ago

but isolatedConfig has been removed from my package.json and warning still shows?

I think I had a similar issue migrating from a 14.8.3 to 17.2.8 forcing to use isolatedConfig in project.json (not package.json) which seems to be fixed by https://github.com/nrwl/nx/issues/20671#issuecomment-1848396559 (not sure why I have to add that webpack.config.js manually though)

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 9 months ago

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

reply

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 9 months ago

The message still appears in this project

I'm seeing the same in this project - maybe that helps to debug it?

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

alextegelid commented 8 months ago

I'm getting this warning today while upgrading to NX 18. Simply removing the line from project.json seems to work, but I'm not sure if that will come back to bite me later.

beeman commented 8 months ago

Simply removing the line from project.json seems to work, but I'm not sure if that will come back to bite me later.

Same, I didn't manually remove it as I hope a migration will do it 'right'.

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 7 months ago

reply 🙌

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 7 months ago

reply

konekoya commented 6 months ago

We're getting this warning as well. We're currently on nx 17.3.2

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 6 months ago

Still happening. 🥲

Would have hoped to see a migration to fix this... Repro linked in my post from early January

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 5 months ago

🙏

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 5 months ago

It will be closed in 21 days if no information is provided.

Working repro here: https://github.com/nrwl/nx/issues/20738#issuecomment-1876727389

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

boltex commented 5 months ago

getting this too on my project

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 4 months ago

Working repro here: https://github.com/nrwl/nx/issues/20738#issuecomment-1876727389

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 4 months ago

🙏

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 4 months ago

image

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

beeman commented 3 months ago

because more information has not been provided within 7 days

🫣

AhmedBHameed commented 3 months ago

We are getting this warning message also in our project.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

chtpl commented 3 months ago

It's still annoying pls fix it!

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

chtpl commented 3 months ago

my goodness ...

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

chtpl commented 3 months ago

Here we go again ...

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

chtpl commented 2 months ago

please at least respond whether this will be fixed

shubham-vunet commented 2 months ago

Similar issue I am facing too.

NX Workspace Version: 19.5.7

beeman commented 2 months ago

It's also still happening in the example I posted like 7 months ago, in case a working demo is needed. https://github.com/nrwl/nx/issues/20738#issuecomment-1876727389

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

chtpl commented 2 months ago

as the bot says It will be closed in 21 days if no information is provided.