search

nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.22k stars 2.31k forks source link

#21428 removed `devDependencies` from package.json #26577

Open TriPSs opened 2 months ago

TriPSs commented 2 months ago

Why? Why is this not made optional (or at-least make this behavior opt in?), as a lib maintainer we add dev dependencies so that

  1. the package is available when we are developing
  2. we can import the package.json and copy it over if needed to the devDependencies of the users project
  3. we can use a tool like ncu to easy update set packages that are added to the users project
  4. we are then not forcing certain versions to our end users

Can we make this behavior opt-in or opt-out?

TriPSs commented 2 months ago

21428, made this ticket with the reference in issue function, sorry that it's not following the format.

FrozenPandaz commented 2 months ago

What are you running where you are seeing the issue? Can you provide a reproduction please to help us reproduce the issue?

TriPSs commented 2 months ago

Here is the commit that changes the implementation we had. These packages where build and released with devDependencies so when running the <package>:init we could read it from there.

We can keep dependencies inside the package.json up to date with tools like ncu, now it will become a manual stap, which will be forgotten.

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

TriPSs commented 2 months ago

I did add more info?

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

TriPSs commented 2 months ago

Again, I did add more info.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

TriPSs commented 1 month ago

Once again, I did add more info @FrozenPandaz

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

TriPSs commented 1 month ago

@jaysoo @FrozenPandaz

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

TriPSs commented 1 month ago

:/

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

TriPSs commented 1 month ago

:/

github-actions[bot] commented 3 weeks ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

TriPSs commented 2 weeks ago

Bump again

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

TriPSs commented 1 week ago

Bump again

github-actions[bot] commented 3 days ago

This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! 🙏

TriPSs commented 3 days ago

Once again, not stale @FrozenPandaz