nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
22.63k stars 2.26k forks source link

CommitReferences are not included in all Changelogs #26651

Open christophsaile opened 1 week ago

christophsaile commented 1 week ago

Current Behavior

In my current setup I want to have one version for all of my packages but indepent changelogs. I need this setup to have a connection between packages and changes. One problem is that only in the root changelog the commit references are added to the changelog.

Expected Behavior

As shown in the documentation the CommitReferences should be included in all generated Changelogs.

GitHub Repo

https://github.com/christophsaile/nx-release-issue

Steps to Reproduce

  1. commit and push some changes
  2. run pnpm release
  3. see that the commit reference is not included in the projects changelog

Nx Report

Node   : 20.9.0
OS     : darwin-arm64
pnpm   : 8.7.6

nx (global)    : 19.0.6
nx             : 19.3.1
@nx/js         : 19.3.1
@nx/workspace  : 19.3.1
@nrwl/tao      : 19.3.1

Failure Logs

No response

Package Manager Version

No response

Operating System

Additional Information

No response

BigWhiteTiger commented 6 days ago

I am encountering a similar behavior, the references for the commits are not included in the project changelogs.

The thing is, that also when switching to a global workspace changelog, the references are also not included. I have set the documented properties within the nx.json explicit to avoid missing default behavior and vice versa.

Only release.changelog.projectChangelogs.renderOptions.authors and release.changelog.projectChangelogs.renderOptions.versionTitleDate does have an effect, but not "commitReferences".

"@nx/workspace": "19.1.2",

BigWhiteTiger commented 6 days ago

Strange behavior:

I tried your repo and have reproduce an issue with the global changelog file. Only if the git remote origin is set to a domain like https://github.com the references got produced (onyl workspace, not projects).

After switching remote origin url to something internal (like own gitlab server) those references in the global changelog are not shown.

I don't know why, but this is very strange, some kind of filtering. So I can agree to @christophsaile that referencing is not working for projects...but even if this got fixed it will not work for me because I have different git remote url.

christophsaile commented 6 days ago

@BigWhiteTiger thanks for investigating. I noticed the same issue. On one of my projects where I use azure devops the reference is not working at all :/