Open nealef opened 1 month ago
Is there a docker image for s390x that I can run locally? It would help me debug the error you have.
You can get your own s390x VM on the Linux Community Cloud system: https://linuxone.cloud.marist.edu/
I also have a github action runner available.
I can also set up an account on a VM I have in the community cloud system.
Build run with: NAPI_RS_FORCE_WASI=true NX_NATIVE_LOGGING=nx RUST_BACKTRACE=1 NX_VERBOSE_LOGGING=true NX_PERF_LOGGING=true
@FrozenPandaz Did these logs help?
This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! π
Noooo.... (on potential auto-close) @FrozenPandaz, please help, when you can.
@nealef I'm going to try to get this reproducible locally. But if you can provide the github runner or a vm (which we can remote into..), this would help us resolve this quicker.
I actually got this reproducible locally using https://hub.docker.com/r/s390x/ubuntu/. So lets see what I can do.
~@nealef I'm going to try to get this reproducible locally. But if you can provide the github runner or a vm (which we can remote into..), this would help us resolve this quicker.~
I actually got this reproducible locally using https://hub.docker.com/r/s390x/ubuntu/. So lets see what I can do.
If it doesn't work out I can supply an account on a VM and/or a github action runner.
Ok, we took some time to figure this out, but we got something.
There appears to be an issue with node < 22.6.0. When we use the lts/iron
(20.16.0) version, we see the issues that are shown here. But updating node to the latest (22.6.0), things run properly.
Try updating your node versions to 22.6.0, and lets see if it resolves the issues experienced.
I'll give it a try in my morning (UTC+10).
-------- Original message -------- From: Jonathan Cammisuli @.> Date: 9/8/24 00:36 (GMT+10:00) To: nrwl/nx @.> Cc: Neale Ferguson @.>, Mention @.> Subject: Re: [nrwl/nx] Problem installing 19.5.2 on s390x (Issue #27104)
Ok, we took some time to figure this out, but we got something.
There appears to be an issue with node < 22.6.0. When we use the lts/iron (20.16.0) version, we see the issues that are shown here. But updating node to the latest (22.6.0), things run properly.
Try updating your node versions to 22.6.0, and lets see if it resolves the issues experienced.
β Reply to this email directly, view it on GitHubhttps://github.com/nrwl/nx/issues/27104#issuecomment-2275991442, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AACLN6QBF635GIFOIT72VY3ZQN66FAVCNFSM6AAAAABLNTRQ6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVHE4TCNBUGI. You are receiving this because you were mentioned.Message ID: @.***>
I canβt find a 22.6 yet. 22.5.1 is βcurrentβ according to the nodejs folks.
https://nodejs.org/en/blog/release/v22.5.1
When it comes out Iβll give it a go.
Found 22.6.0 and used it to try and do:
Attached are the log files (build.log
for (1) and nx.log
for (2)) and the Dockerfiles I used to perform the work (Dockerfile.build
for (1) and Dockerfile.nx
for (2)).
Building Nx isn't something that you need to do, so I'm not going to focus on those errors atm.
As for the dockerfile.build
, this error:
#19 1.387 Error: Cannot find module '@napi-rs/wasm-runtime'
#19 1.387 Require stack:
#19 1.387 - /go/src/github.com/grafana/node_modules/nx/src/native/nx.wasi.cjs
Is showing me that the dependencies weren't installed properly. '@napi-rs/wasm-runtime'
is a direct dependency on nx
(https://www.unpkg.com/nx@19.5.6/package.json)
I see that you're directly installing nx with npm on line 27, but then doing a yarn install on line 50. Looking at the repo that is cloned, the version of Nx there is 19.2.0. Make sure that nx is using the correct version in the package.json, as doing a yarn install will overwrite some files in the node_modules
directory if it was previously installed by another package manager.
I managed to get the dockerfile built. I followed the advice I given (making sure that nx is set to 19.5.6 in the package.json) and things are working.
@Cammisuli If you can, please share the assets so I can try to build too. I will also have to try & build this outside of a container for a 'system' install.
EDIT: Mainly just wondering what goes in grafana.patch
.
I assume you just removed the separate install of nx and let it happen as part of the grafana build? There was one instance of 19.2.0 in package.json
and multiple occurrences in yarn.lock
. I had changed both with this grafana.patch.
When I build I get:
#17 309.0 β€ YN0009: β nx@npm:19.5.6 [231b4] couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-813142f1/build.log)
#17 407.5 β€ YN0000: β Completed in 4m 59s
#17 409.0 β€ YN0000: Β· Failed with errors in 6m 46s
The build.log is here: grafana.log.
I tried building from this branch, which is nx @ 19.5.7, with related updates to lock files.
nodejs 22.6 go 1.22.6 yarn set 4.4.0
make deps
issues the command: yarn install --immutable
, which finished with some warnings.
make deps-go
, which says:
And finally make build
, which fails.
Additional info:
$ yarn nx show projects
NX The Nx Daemon is unsupported in WebAssembly environments. Some things may be slower than or not function as expected.
@grafana-plugins/grafana-postgresql-datasource
@grafana-plugins/grafana-pyroscope-datasource
@grafana-plugins/grafana-testdata-datasource
@grafana-plugins/stackdriver
@grafana-plugins/grafana-azure-monitor-datasource
@grafana-plugins/jaeger
@grafana-plugins/zipkin
@grafana-plugins/mysql
@grafana-plugins/parca
@grafana-plugins/tempo
@grafana/o11y-ds-frontend
@grafana/plugin-configs
@grafana/e2e-selectors
@grafana/eslint-plugin
@grafana/flamegraph
@grafana/prometheus
@grafana/runtime
@grafana/schema
@grafana/saga-icons
@grafana/data
@grafana/sql
@grafana/ui
grafana
$ yarn nx report
NX The Nx Daemon is unsupported in WebAssembly environments. Some things may be slower than or not function as expected.
NX Report complete - copy this into the issue template
Node : 22.6.0
OS : linux-s390x
Native Target : wasm32
yarn : 4.4.0
nx : 19.5.7
lerna : 8.1.8
@nx/devkit : 19.0.8
@nrwl/tao : 19.5.7
typescript : 5.4.5
---------------------------------------
The following packages should match the installed version of nx
- @nx/devkit@19.0.8
- @nrwl/devkit@19.0.8
To fix this, run `nx migrate nx@19.5.7`
Oh the memory access out of bounds while building is definitely not good. I'll see whats up with that.
@ProximaB - your comment is unrelated. Please open a new issue?
This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! π
Comment for activity. This is still an issue... Hey @Cammisuli, did you get a chance to look?
This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! π
Gentle poke, @Cammisuli
Sorry about that! I got a little sidetracked with some other projects. I still have this on my radar
This issue has been automatically marked as stale because more information has not been provided within 7 days. It will be closed in 21 days if no information is provided. If information has been provided, please reply to keep it active. Thanks for being a part of the Nx community! π
I gave 19.7.2 a run and the problem still exists. I have a log of the run. Note I filtered out hundreds of nx::native::tasks::task_hasher:
debug messages just to reduce the log file size.
build.log.txt
Current Behavior
npm install nx@19.5.2
results in:NAPI_RS_FORCE_WASI=true npm install nx@19.5.2
results in:Expected Behavior
Clean installation.
GitHub Repo
No response
Steps to Reproduce
On a s390x host:
npm install nx@19.5.2
orNAPI_RS_FORCE_WASI=true npm install nx@19.5.2
Nx Report
Failure Logs
Package Manager Version
npm@10.8.2
Operating System
Additional Information
Applying this patch results in
NAPI_RS_FORCE_WASI=true
behaviour when runningnpm install nx@19.5.2
: