nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.58k stars 2.36k forks source link

upgrade @typescript-eslint/parser to v8 for @nx/eslint-plugin #27449

Closed EelcoLos closed 2 months ago

EelcoLos commented 2 months ago

Current Behavior

Currently, trying to upgrade, npm-check-updates will state

@typescript-eslint/parser: @nx/eslint-plugin requires ^6.13.2 || ^7.0.0

while its companion @typescript-eslint/eslint-plugin 7.17.0 → 8.1.0 states that v.8.1.0 is available

Expected Behavior

to be able to update @typescript-eslint/parser to v8 and up as well

GitHub Repo

No response

Steps to Reproduce

  1. try updating packages with peer dependencies

Nx Report

NX   Report complete - copy this into the issue template

Node           : 20.16.0
OS             : win32-x64
Native Target  : x86_64-windows
npm            : 10.8.2

nx (global)        : 19.5.7
nx                 : 19.5.7
@nx/js             : 19.5.7
@nx/jest           : 19.5.7
@nx/linter         : 19.5.7
@nx/eslint         : 19.5.7
@nx/workspace      : 19.5.7
@nx/angular        : 19.5.7
@nx/devkit         : 19.5.7
@nx/eslint-plugin  : 19.5.7
@nx/playwright     : 19.5.7
@nx/plugin         : 19.5.7
@nrwl/tao          : 19.5.7
@nx/web            : 19.5.7
@nx/webpack        : 19.5.7
typescript         : 5.5.4
---------------------------------------
Registered Plugins:
@nx/eslint/plugin
@nx-dotnet/core
@nx/jest/plugin
---------------------------------------
Community plugins:
@fortawesome/angular-fontawesome : 0.15.0
@ngrx/component                  : 18.0.2
@ngrx/component-store            : 18.0.2
@ngrx/effects                    : 18.0.2
@ngrx/entity                     : 18.0.2
@ngrx/router-store               : 18.0.2
@ngrx/schematics                 : 18.0.2
@ngrx/store                      : 18.0.2
@ngrx/store-devtools             : 18.0.2
@nx-dotnet/core                  : 2.4.3

Failure Logs

No response

Package Manager Version

No response

Operating System

Additional Information

It also states that this update is needed for potential eslint 9 upgrade

mtalhafaheem commented 2 months ago

I am also facing the same issue. Please do let me know if you find any solution.

JamesHenry commented 2 months ago

This should land in Nx 19.7 by the end of the month, you can follow along with https://github.com/nrwl/nx/issues/27451 which I have created to avoid the multiple duplicates we currently have open.

The WIP PR is getting very close, so stay tuned. It's not easy because of a large differences in ESLint v9 support across ESLint plugins that Nx sets up for you.

EelcoLos commented 2 months ago

thanks for the resolution. the github search of this issue didn't show the similar issues.

github-actions[bot] commented 1 month ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.