nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.56k stars 2.36k forks source link

[Import] Nx Import doesn't move tags #28171

Open DanielRivers opened 1 month ago

DanielRivers commented 1 month ago

Current Behavior

import project using nx import command imports the commits all good, however the tags are left on what appears to be a shadow commit tree and new tags are not created or moved over.

Expected Behavior

Tags moved to the new commits, ideally with the project prefix in format which will work with nx release

GitHub Repo

https://github.com/DanielRivers/nx-import-demo

Steps to Reproduce

  1. run nx import importing from a repo with tags
  2. View tags on local git, will not be attached to any commit

Nx Report

NX   Report complete - copy this into the issue template

Node           : 22.0.0
OS             : darwin-arm64
Native Target  : aarch64-macos
pnpm           : 8.14.1

nx (global)        : 19.4.2
nx                 : 19.8.2
@nx/js             : 19.8.2
@nx/workspace      : 19.8.2
@nx/eslint-plugin  : 19.8.2
@nx/vite           : 19.8.2
@nx/web            : 19.8.2
---------------------------------------
Registered Plugins:
@nx/vite/plugin

Failure Logs

No response

Package Manager Version

pnpm 8.14.1

Operating System

Additional Information

Viewing tag shows

image

https://github.com/DanielRivers/nx-import-demo/commit/375a26094270cfc8cacb61d4bfbc6aeeb471b583

ken-playerlync commented 2 weeks ago

I'm not even able to get this command to work... I keep getting an NX Cannot find project error when I run nx import [source] [dest], even when I pass it a valid github url....

DanielRivers commented 2 weeks ago

@ken-playerlync What I did was just run nx import and followed the commands

ken-playerlync commented 2 weeks ago

@ken-playerlync What I did was just run nx import and followed the commands

@DanielRivers was your source project already a nx monorepo project?

DanielRivers commented 1 week ago

@ken-playerlync What I did was just run nx import and followed the commands

@DanielRivers was your source project already a nx monorepo project?

No

DanielRivers commented 1 week ago

HI @jaysoo , I can see you self assigned this, I am wondering if have any idea on resolution, I have approx 10 projects wanting to move into a NX monorepo and holding off until we can import with tags and them work in a way which will work with nx release ideally.