search

nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.75k stars 2.37k forks source link

fix(core): lower socket path by 10 chars to reduce chances of too-long paths #28920

Closed MaxKless closed 1 week ago

MaxKless commented 1 week ago

Current Behavior

Socket paths have quite a short allowed length. It's easy to hit the maximum.

Expected Behavior

We should exceed the maximum as rarely as possible. By lowering the workspacePath hash portion, we reduce the chances of exceeding the path.

Related Issue(s)

Fixes https://github.com/nrwl/nx/issues/27725

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **nx-dev** | ⬜️ Ignored ([Inspect](https://vercel.com/nrwl/nx-dev/HBazHKoxwYNjtBDSbTAZQfgoJCPN)) | [Visit Preview](https://nx-dev-git-socket-path-10-chars-nrwl.vercel.app) | Nov 13, 2024 2:06pm |
nx-cloud[bot] commented 1 week ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 76e2b49211b558e187ae45ec4aa74b23903c484b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets - [`nx affected --targets=lint,test,build,e2e,e2e-ci --base=6882ad14e401df4331f69d80780f0921894da66d --head=76e2b49211b558e187ae45ec4aa74b23903c484b --parallel=3`](https://staging.nx.app/runs/1wn4nKcuFL?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte`](https://staging.nx.app/runs/YuVlfMvTZq?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- nx format:check --base=6882ad14e401df4331f69d80780f0921894da66d --head=76e2b49211b558e187ae45ec4aa74b23903c484b`](https://staging.nx.app/runs/915tehqSro?utm_source=pull-request&utm_medium=comment) - [`nx documentation --no-dte`](https://staging.nx.app/runs/0tJ5GQ4SeD?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 2 days ago

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.