search

nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.78k stars 2.37k forks source link

fix(rspack): withModuleFederationForSSR should use commonjs-module as library #28944

Closed Coly010 closed 1 week ago

Coly010 commented 1 week ago

Current Behavior

When navigating directly to a route that renders a portion of a remote app, SSR was not correctly server rendering the remote portion. This was because of the output type provided to rspack and MFP

Expected Behavior

Ensure commonjs-module is set as output type for MF with SSR

Related Issue(s)

Fixes #

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **nx-dev** | ⬜️ Ignored ([Inspect](https://vercel.com/nrwl/nx-dev/BKV2X6wtX58uJZDB6KNJwwFs6zv3)) | [Visit Preview](https://nx-dev-git-rspack-fix-with-mf-ssr-nrwl.vercel.app) | Nov 14, 2024 8:00pm |
nx-cloud[bot] commented 1 week ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bf45bb339ce07ec064b7a90c5307fd651d691874. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets - [`nx affected --targets=lint,test,build,e2e,e2e-ci --base=da60c38a3457a0076f4e913b7f51e4a9b0b8097d --head=bf45bb339ce07ec064b7a90c5307fd651d691874 --parallel=3`](https://staging.nx.app/runs/6t33mpr02f?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte`](https://staging.nx.app/runs/woCDNerEns?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- nx format:check --base=da60c38a3457a0076f4e913b7f51e4a9b0b8097d --head=bf45bb339ce07ec064b7a90c5307fd651d691874`](https://staging.nx.app/runs/zgHVDs850d?utm_source=pull-request&utm_medium=comment) - [`nx documentation --no-dte`](https://staging.nx.app/runs/iRxi21sSNs?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 5 days ago

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.