search

nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.75k stars 2.37k forks source link

fix(core): ensure process is kept alive when plugin communication in progress #28948

Closed AgentEnder closed 6 days ago

AgentEnder commented 1 week ago

Current Behavior

When using NX_PLUGIN_NO_TIMEOUTS there is not a reference counted as the setTimeout is not called. This could theoretically result in node killing the process if the only thing that was keeping it alive was the plugin call.

Expected Behavior

A ref is tracked either way to prevent the process from getting dropped.

Related Issue(s)

Fixes #

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **nx-dev** | ⬜️ Ignored ([Inspect](https://vercel.com/nrwl/nx-dev/7fw86bgjTkzcioRddC3AWv2iu3DG)) | [Visit Preview](https://nx-dev-git-fix-plugin-pool-timeouts-nrwl.vercel.app) | Nov 14, 2024 10:47pm |
nx-cloud[bot] commented 1 week ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7a59f81c22355a8fe5b24dccf7fc68f6cb7c464c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets - [`nx affected --targets=lint,test,build,e2e,e2e-ci --base=08953af5ec646cfc06333c2068438b878e7d2e28 --head=7a59f81c22355a8fe5b24dccf7fc68f6cb7c464c --parallel=3`](https://staging.nx.app/runs/JAAW36siiN?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte`](https://staging.nx.app/runs/BLNXwNoAr3?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- nx format:check --base=08953af5ec646cfc06333c2068438b878e7d2e28 --head=7a59f81c22355a8fe5b24dccf7fc68f6cb7c464c`](https://staging.nx.app/runs/lU0Dq0aIPK?utm_source=pull-request&utm_medium=comment) - [`nx documentation --no-dte`](https://staging.nx.app/runs/4yxeCyHLZv?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 1 day ago

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.