nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.75k stars 2.37k forks source link

fix(rspack): buildLibsFromSource option #28994

Closed ndcunningham closed 2 days ago

ndcunningham commented 2 days ago

Current Behavior

Currently, the buildLibsFromSource option is not being used. So even if the user sets it to 'buildLibsFromSource': false it will not be updated.

Expected Behavior

The buildLibsFromSource should be supported.

Related Issue(s)

There is an issue with Rspack that requires the baseUrl to be set in the generated tsconfig.

Fixes #

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **nx-dev** | ⬜️ Ignored ([Inspect](https://vercel.com/nrwl/nx-dev/H5Tq8W8W8afqJU9LsEg2vJg1nUJV)) | [Visit Preview](https://nx-dev-git-fix-rspack-libs-from-source-nrwl.vercel.app) | Nov 19, 2024 6:44pm |
nx-cloud[bot] commented 2 days ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3dbef5f45ba06fa78a81425bd487b7807cd51bcc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets - [`nx affected --targets=lint,test,build,e2e,e2e-ci --base=76d61ea5e6f1920629ab6c88fb9d27220c233375 --head=3dbef5f45ba06fa78a81425bd487b7807cd51bcc --parallel=3`](https://staging.nx.app/runs/ETXDGkmxqe?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte`](https://staging.nx.app/runs/pi9x3n609g?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- nx format:check --base=76d61ea5e6f1920629ab6c88fb9d27220c233375 --head=3dbef5f45ba06fa78a81425bd487b7807cd51bcc`](https://staging.nx.app/runs/X8NZgx0OWF?utm_source=pull-request&utm_medium=comment) - [`nx documentation --no-dte`](https://staging.nx.app/runs/gvuDRWy0z4?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.