nrwl / nx

Smart Monorepos · Fast CI

https://nx.dev

MIT License

23.75k stars 2.37k forks source link

fix(core): add missing supported CI providers to `NxCloud` type #29008

Closed tinesoft closed 1 day ago

tinesoft commented 1 day ago

Current Behavior

CreateWorkspaceOptions that is exposed via the create-nx-workspace package, https://github.com/nrwl/nx/blob/a0d760f7902b09eb2cf77f0cd83e2157669c794d/packages/create-nx-workspace/src/create-workspace-options.ts#L7

has a field named NxCloud that only contains the following types:, https://github.com/nrwl/nx/blob/1c2ae37b6e7c9e58dbdf10dc8cd614dcb5886178/packages/create-nx-workspace/src/utils/nx/nx-cloud.ts#L5

while more CI providers are in fact supported by the underlying code (see NxCloudChoices array in ab-testing.ts):

https://github.com/nrwl/nx/blob/a0d760f7902b09eb2cf77f0cd83e2157669c794d/packages/create-nx-workspace/src/utils/nx/ab-testing.ts#L5

Expected Behavior

Align the type of NxCloud to match all supported values from NxCloudChoices

Related Issue(s)

Fixes #

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

nx-cloud[bot] commented 1 day ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c01e67614c7c0d14b4b36ad3a43428d2d41a7f30. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

- [`nx affected --targets=lint,test,build,e2e,e2e-ci --base=1c2ae37b6e7c9e58dbdf10dc8cd614dcb5886178 --head=c01e67614c7c0d14b4b36ad3a43428d2d41a7f30 --parallel=3`](https://staging.nx.app/runs/PIdVUD0qYH?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte`](https://staging.nx.app/runs/CPFn1BducT?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- nx format:check --base=1c2ae37b6e7c9e58dbdf10dc8cd614dcb5886178 --head=c01e67614c7c0d14b4b36ad3a43428d2d41a7f30`](https://staging.nx.app/runs/f2zrjrJQvj?utm_source=pull-request&utm_medium=comment) - [`nx documentation --no-dte`](https://staging.nx.app/runs/zKfvhBYPJT?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.