search

nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.75k stars 2.37k forks source link

fix(remix): remove tooling packages from generated package.json since they are installed in the root #29009

Closed jaysoo closed 1 day ago

jaysoo commented 1 day ago

The eslint version is causing errors like:

Error while loading rule '@typescript-eslint/no-unused-expressions': Cannot read properties of undefined (reading 'allowShortCircuit')

This is because we are installing both eslint 8 and 9 to the workspace, which are not compatible. We shouldn't need to add eslint, typescript, vite and other tooling to the app's package.json since they should following single version policy by default and be installed at the root.

Note: This is only an issue when you enable workspaces.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **nx-dev** | ⬜️ Ignored ([Inspect](https://vercel.com/nrwl/nx-dev/E3zir3amHahP45iM858ZDdSJEENy)) | [Visit Preview](https://nx-dev-git-fix-remix-eslint-nrwl.vercel.app) | Nov 20, 2024 4:07pm |
nx-cloud[bot] commented 1 day ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c236f29ad653727208ca684f57717569f33f8802. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets - [`nx affected --targets=lint,test,build,e2e,e2e-ci --base=ce6caba1f9cfb4f61ef142c40d1ea30a421ffa9a --head=c236f29ad653727208ca684f57717569f33f8802 --parallel=3`](https://staging.nx.app/runs/G5GmoFvNo4?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte`](https://staging.nx.app/runs/4VBAO9b4AT?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- nx format:check --base=ce6caba1f9cfb4f61ef142c40d1ea30a421ffa9a --head=c236f29ad653727208ca684f57717569f33f8802`](https://staging.nx.app/runs/ma9FazbkHI?utm_source=pull-request&utm_medium=comment) - [`nx documentation --no-dte`](https://staging.nx.app/runs/gNJQcQp7wQ?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.