nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.75k stars 2.37k forks source link

fix(angular): make scam-to-standalone replace correct module #29014

Closed Olster closed 1 day ago

Olster commented 1 day ago

Current Behavior

Without this fix, the regular expression would replace other modules that have old module name in their name.
E.g. MapIconModule contains IconModule and when migrating IconModule, the migration would wrongfully update MapIconModule to MapIconComponent.

Expected Behavior

Migration changes only the Module/Component that's being migrated.

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **nx-dev** | ⬜️ Ignored ([Inspect](https://vercel.com/nrwl/nx-dev/GAbpCq9jPeQ3qnwCaAcWjmumQCiP)) | [Visit Preview](https://nx-dev-git-fork-olster-scam-to-standalone-fix-nrwl.vercel.app) | Nov 20, 2024 8:11pm |
nx-cloud[bot] commented 1 day ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 04d07a3ab409eb5b21f2b0d2cc39aa7c99a8f6de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets - [`nx affected --targets=lint,test,build,e2e,e2e-ci --base=8f67441e63f4c3def119f7734db7543ce0eeb7df --head=04d07a3ab409eb5b21f2b0d2cc39aa7c99a8f6de --parallel=3`](https://staging.nx.app/runs/GWZ6oXOdGD?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte`](https://staging.nx.app/runs/naFY71dPtm?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- nx format:check --base=8f67441e63f4c3def119f7734db7543ce0eeb7df --head=04d07a3ab409eb5b21f2b0d2cc39aa7c99a8f6de`](https://staging.nx.app/runs/dZBOBt01wy?utm_source=pull-request&utm_medium=comment) - [`nx documentation --no-dte`](https://staging.nx.app/runs/BoRjApjcUo?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.