search

nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.27k stars 2.32k forks source link

[Feature Request] Option --ignoreTestFiles cli argument not exposed by the cypress builder #3439

Closed jacobworrel closed 4 years ago

jacobworrel commented 4 years ago

Description

I would like to be able to ignore test files via the cypress ignoreTestFiles cli argument. Currently, when trying to run nx e2e my-app-e2e --ignoreTestFiles=path/to/file, I get the following error:

Schema validation failed with the following errors:
  Data path "" should NOT have additional properties(ignoreTestFiles).

Motivation

I want to ignore tests that run visual regression tests on applitools while running e2e tests in watch mode. My current workaround is to duplicate the cypress.json file with a ignoreTestFiles prop and pass that in via the cypress-config cli flag.

Suggested Implementation

The implementation for https://github.com/nrwl/nx/issues/1192 should work for this flag as well.

FrozenPandaz commented 4 years ago

That sounds like an important flag for the builder to accept.

As mentioned, this is a relatively simple feature and someone from the community can send a PR! :pray:

mehrad-rafigh commented 4 years ago

@FrozenPandaz @jacobworrel I will take a try at this and open a PR

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.