search

nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.63k stars 2.36k forks source link

Outlet is not activated #436

Closed jbeckton closed 6 years ago

jbeckton commented 6 years ago

I have had problems with the StoreRouterConnectingModule on multiple angular ngrx apps even outside of NX workspaces. With NX I have seen the error "Outlet is not activated" when lazy loading feature module libraries. The fix was to override the RouterStateSerializer with a custom serializer in all cases.

Generating a simple NX workspace with one app and one routed feature lib is broken out of the box. Maybe consider adding to the generator a custom serializer to prevent this issue.

vsavkin commented 6 years ago

If i understand the issue correctly, it should be addressed in NgRx 6 (see here: https://github.com/ngrx/platform/pull/901), which should be released soon.

Meanwhile, I'll add the serializer to Nx.

fateh14 commented 6 years ago

still getting this error :/, nx version: "@nrwl/nx": "6.1.1",

the error is gone after commenting storeFreeze

StoreModule.forRoot( {}, { metaReducers: !environment.production ? [/*storeFreeze*/] : [] } ),

is there a solution

davidreher commented 6 years ago

@vsavkin: Is it save to update to NgRx 6? Is it supported with Nx 6?

FrozenPandaz commented 6 years ago

It is now safe to update to @ngrx@6 (in fact it's automatically migrated to) so this should no longer be an issue. 👍

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.