Problem running Storybook on mixed workspaces

mandarini commented 3 years ago

Current Behavior

On a mixed workspace, when Storybook is added on a different framework it does not run. eg. Workspace with Angular and React libs/apps Add Storybook in React lib or app Works/runs Add Storybook in Angular lib or app Storybook is generated Storybook does not run

Expected Behavior

Storybook works on mixed workspaces.

Steps to Reproduce

Scenario 1:

create-nx-workspace with react app
Generate react lib as well, and one component in react lib, one component in react app
@nrwl/react:storybook-configuration schematic for react lib and react app
nx run <app and lib>:storybook
SUCCESS!!

Scenario 2:

In same workspace, generate ANGULAR lib
generate angular component inside angular lib
@nrwl/angular:storybook-configuration for angular lib
nx run <angular lib>:storybook
ERROR: Cannot find module '@storybook/angular/dist/server/options'

And vice-versa

mandarini commented 3 years ago

@juristr I created this issue

ringodotnl commented 3 years ago

@mandarini getting the same issue with:

setup as angular (npx create-nx-workspace --preset=angular)
add library (nx generate @nrwl/angular:library sharedlibrary --directory shared --strict --publishable --importPath @myorg/sharedlibrary --buildable --style=scss)
add storybook (nx generate @nrwl/angular:storybook-configuration shared-sharedlibrary --generateStories --configureCypress --generateCypressSpecs)
nx run shared-sharedlibrary:storybook

also gives: ERROR: Cannot find module '@storybook/angular/dist/server/options'

nayfin commented 3 years ago

I updated @nrwl/storybook to "^11.6.0" and @storybook/angular to "^6.2.1", and that seems to have fixed it. Maybe migrations can be updated to account for this?

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

nrwl / nx