nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.29k stars 2.32k forks source link

Upgrade Karma for @nrwl/angular #8961

Closed sir-captainmorgan21 closed 2 years ago

sir-captainmorgan21 commented 2 years ago

Description

The generator for @nrwl/angular for karma has out-of-date versions. Some of the features are incompatible with NG13, like coverage reporting. Can we get these up to date?

Motivation

I ran into an issue running unit tests for my angular components when I attempted to turn on coverage reporting. The fix was to upgrade karma, drop the use of karma-coverage-istanbul, add karma-coverage and update the karma.conf.js. It would probably be nice to include an upgrade generator as well.

Suggested Implementation

Just updating the packages and updating the karma.conf template. Creating an upgrade command to update workspaces

Alternate Implementations

Got none

sir-captainmorgan21 commented 2 years ago

@Coly010 been crushing all my issues. Thanks man!

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.