nrwl / nx

Smart Monorepos · Fast CI
https://nx.dev
MIT License
23.81k stars 2.38k forks source link

Storybook: support generating stories for components in secondary entrypoints #9045

Closed pvds closed 2 years ago

pvds commented 2 years ago

Description

It seems that generating stories for components, using nx g @nrwl/angular:stories <project-name>, currently only works for components declared in the primary entrypoint of a library, not for components declared in secondary entrypoints.

Motivation

Since secondary entrypoints have been introduced in NX devtools 13.1 to enhance library architecture, support treeshaking, it makes sense to support being able to generate stories for the components declared in those entrypoints.

Suggested Implementation

Generate stories for both primary and secondary entrypoints when running nx g @nrwl/angular:stories <project-name>

Alternate Implementations

pvds commented 2 years ago

@mandarini @vsavkin any thoughts on this?

mandarini commented 2 years ago

Hi there @pvds ! We'll add this in the plans to take a look as a new feature. In the meantime, if you think you're up for it, let me know if you want to give this a shot! I can help you out!

pvds commented 2 years ago

@mandarini thanks, I'll reach out when I find some time.

mandarini commented 2 years ago

@pvds hey! Can you retry with latest version of Nx? I have a feeling that this is now fixed! :)

mandarini commented 2 years ago

Hi there @pvds ! I'll go ahead and close this, because I'm pretty sure that's fixed in the latest version of Nx. If you find that the issue persists, please feel free to reopen! :)

SvenBudak commented 2 years ago

i can not confirm that this is working... i use 14.5.1 and its not working for second entrypoint components

mandarini commented 2 years ago

Thanks for opening #11446 @SvenBudak !

github-actions[bot] commented 1 year ago

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.