web:rollup executor doesn't produce declarations with compiler set to swc

[j3ski]

Current Behavior

When running nx build for my buildable library I don't get d.ts files in the output directory.

Expected Behavior

d.ts files should be generated.

Steps to Reproduce

1. Generate a buildable library with --compiler swc
2. Build it

Environment

Node : 16.10.0
   OS   : darwin arm64
   yarn : 1.22.17

   nx : 13.8.3
   @nrwl/angular : undefined
   @nrwl/cli : 13.8.3
   @nrwl/cypress : 13.8.3
   @nrwl/detox : undefined
   @nrwl/devkit : 13.8.3
   @nrwl/eslint-plugin-nx : 13.8.3
   @nrwl/express : undefined
   @nrwl/jest : 13.8.3
   @nrwl/js : 13.8.3
   @nrwl/linter : 13.8.3
   @nrwl/nest : undefined
   @nrwl/next : undefined
   @nrwl/node : undefined
   @nrwl/nx-cloud : undefined
   @nrwl/react : 13.8.3
   @nrwl/react-native : undefined
   @nrwl/schematics : undefined
   @nrwl/storybook : 13.8.3
   @nrwl/tao : 13.8.3
   @nrwl/web : 13.8.3
   @nrwl/workspace : 13.8.3
   typescript : 4.4.4
   rxjs : 6.6.7
   ---------------------------------------
   Community plugins:

[FrozenPandaz]

I see this resolved in the latest Nx. Can you please retry with the latest version?

In fact, I also see it resolved in 13.8.3. :thinking:

If you do not see this resolved, can you please provide a repo so we can reproduce the issue?

[j3ski]

Hi @FrozenPandaz No, this is not resolved in the latest Nx. I am able to reproduce it with 13.8.8. Here is a repo: https://github.com/j3ski/nx-react-swc

[owen26]

I'm having the same issue too. And from what I can see in the swc thread

https://github.com/swc-project/swc/issues/657

It seems like a missing feature so I thought the missed types in NX are expected.

Not a big issue for compiling and bundling apps, but for libs that mean to be published to NPM, this is an essential feature.

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[j3ski]

Ping. Still relevant.

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[nezdemkovski]

Still relevant

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[sergiocarneiro]

This issue still exists

[sahil-shubham]

Still relevant. Had to change compiler to babel in project.json to fix it.

[kjrocker]

I also ran into this issue. Having to switch back to babel and lose my SWC performance improvements

[tobysmith568]

@FrozenPandaz would you consider removing the blocked tag that you added to this? This issue is still present in the latest version

[jeffgaynor]

Same experience here with swc vs babel.

[tobysmith568]

Thanks for re-opening, @FrozenPandaz. What needs to be done to remove the blocked tag? Other people above have posted repros

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[nezdemkovski]

Still relevant.

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[tobysmith568]

Still relevant.

[romhayh]

Still relevant

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[tobysmith568]

Still relevant.

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[mhabegger]

Does anyone know what and where something needs to be addressed? Is it a swc issue?

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[nezdemkovski]

Still relevant

[mderkach]

Still relevant

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[tobysmith568]

Still relevant

[Chanki-Min]

because of this line, when we use swc, tsc is not running, so no d.t.s files

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[miguelmoreba]

This is still relevant

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[HashemKhalifa]

This is still relevant

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[hishamhaniffa]

This is still relevant

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[romhayh]

Still relevant

[DreadfulBot]

• stil relevant

[ShayDavidson]

still relevant

[ShayDavidson]

Based on the comment by @Chanki-Min, I've created a custom version of the rollup executor that includes the missing useSwc check:

Just add these 4 files into a folder in your mono-repo, e.g. ./executors/rollup: https://gist.github.com/ShayDavidson/e89751a5bc57a17ca6846dfd68aabf45

And then in the project.json, reference it like this:

"build": {
      "executor": "./executors/rollup:rollup",
     ...
}

It does generate the type declarations, but I'm not sure if there are other bad side-effects of this (will update this comment if I find any).

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[DreadfulBot]

active

[noneall]

this is still relevant

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[pawanrana1992]

How it can be close, it is still relevant. without giving and reply and resulations, this thread closed multiple times. Dear team please provide the valid fix for this. bcs of this issue, me and my team are not able to directly use the nx, and in this case need to use babel instead of swc with webpack instead of NX !!!!

[Chanki-Min]

Seems like nx contributers has busy days. I'm gonna make PR for this (in weekends?)

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. If we missed this issue please reply to keep it active. Thanks for being a part of the Nx community! 🙏

[YonatanKra]

Can this be solved? It still happens in the latest 15.x and 16.x

[Chanki-Min]

this issue fixed by https://github.com/nrwl/nx/pull/18342

cc @YonatanKra

[Chanki-Min]

Can we close this issue @jaysoo ?

Seems like this closed by #18342