search

nrwl / precise-commits

:sparkles: Painlessly apply Prettier by only formatting lines you have modified anyway!
MIT License
471 stars 20 forks source link

Precommit after the original prettier formating #5

Closed defusioner closed 6 years ago

defusioner commented 6 years ago

Hey there! We are about to inject prettier to our project, so we looked for manual/automatic ways of its usage.

When I run Prettier manually on a .js file, and then commit it using precommit (thanks for the fix in #2 ), I get the same error as in that ticket:

 SyntaxError: Unexpected token (5:9)
  4 |         // code
> 5 |       } else {
    |         ^
  6 |         // code
  7 |       }

However, if I don't call prettier manually, there is no problem.

JamesHenry commented 6 years ago

Hi @defusioner, we will definitely need more information here.

The output you have pasted does not contain any stack trace so it is impossible to tell what is happening. I don't think your issue is related to #2 from your description.

The best way to help us dig into the issue you are facing is by providing a minimal reproduction of the issue.

defusioner commented 6 years ago

Seems that this is no longed reproducible in 1.10.1 @JamesHenry

JamesHenry commented 6 years ago

Thanks for letting me know!