Closed mdp21oe closed 3 months ago
Thanks Ns-Rse/Sheffield-Thyroid,
Will make these changes and keep cracking on further.... been reading about ridge regression, lasso regression and cross validation - some knowledge is helping to demystify things ha.
BW Ovie
On Tue, 7 May 2024 at 13:21, Neil Shephard @.***> wrote:
@.**** requested changes on this pull request.
Good start @mdp21oe https://github.com/mdp21oe I noticed on tpyo and have made a few other minor suggestions.
In index.qmd https://github.com/ns-rse/sheffield-thyroid/pull/20#discussion_r1592383441 :
- "compressive_symtoms",
- "hypertension",
- "vocal_cord_paresis",
- "graves_disease",
- "hashimotos_thyroiditis",
- "family_history_thyroid_cancer",
- "exposure_radiation",
- "final_pathology",
- )) |>
- gtsummary::tbl_summary(by = final_pathology) |>
- gtsummary::modify_caption("Clinical characteristics between benign and malignant thyrioid nodules") +clinical_charac +print(colnames(clinical_charac)) +```
@.***_charac shows the destribution of clinical variables evaluated between benign and malignant thyroid nodules.
Tpyo... ⬇️ Suggested change
@._charac shows the destribution of clinical variables evaluated between benign and malignant thyroid nodules. @._charac shows the distribution of clinical variables evaluated between benign and malignant thyroid nodules.
In index.qmd https://github.com/ns-rse/sheffield-thyroid/pull/20#discussion_r1592388441 :
+#| warning: false +#| tbl-caption: "" +patient_demo <- df |>
- dplyr::ungroup() |>
- dplyr::select(c("age_at_scan", "gender", "ethnicity")) |>
- gtsummary::tbl_summary() |>
- gtsummary::modify_caption("Demographics of study population") +patient_demo +print(colnames(patient_demo)) +```
@.***_demo shows the demographics of patients included in this study. A total of
r n_obs
patients were included in +this study with a median (IQR) age ofr gtsummary::inline_text(patient_demo, variable="age_at_scan")
.+```{r} +#| label: clinical_charac
No harm in using full words, most IDE's, including RStudio automatically recognise when you are typing references and allow you to hit TAB to auto-complete, saving you typing. ⬇️ Suggested change
-#| label: clinical_charac +#| label: clinical_characteristics
Same is true for other section label.
Abbreviations and acronyms place a burden/over-head on the reader to decipher them, whilst you or I may be familiar with common usages others may not be, so it helps with readability to be explicit.
In index.qmd https://github.com/ns-rse/sheffield-thyroid/pull/20#discussion_r1592389438 :
- dplyr::select(c("age_at_scan", "gender", "ethnicity")) |>
- gtsummary::tbl_summary() |>
- gtsummary::modify_caption("Demographics of study population") +patient_demo +print(colnames(patient_demo)) +```
@.***_demo shows the demographics of patients included in this study. A total of
r n_obs
patients were included in +this study with a median (IQR) age ofr gtsummary::inline_text(patient_demo, variable="age_at_scan")
.+```{r} +#| label: clinical_charac +#| eval: true +#| echo: false +#| warning: false +#| tbl-caption: ""
Not sure if the caption defined below in gtsummary::modify_caption() is showing for you but if not you could copy and paste it here.
— Reply to this email directly, view it on GitHub https://github.com/ns-rse/sheffield-thyroid/pull/20#pullrequestreview-2043022084, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDMROBQHXUGTC5KF4XF4RNDZBDBNXAVCNFSM6AAAAABHJXDCUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBTGAZDEMBYGQ . You are receiving this because you were mentioned.Message ID: @.***>
Descriptive stats between benign and malignant nodules