search

ns1 / ns1-go

Golang API client for NS1
Apache License 2.0
34 stars 59 forks source link

feat: allow empty tags in record/zone dns model #195

Closed fgouteroux closed 1 year ago

fgouteroux commented 1 year ago

Hello,

In order to add the support of tags in ns1_zone and ns1_record of the terraform-provider-ns1, we need to allow setting empty tags in the record and zone dns model. See https://github.com/ns1-terraform/terraform-provider-ns1/pull/279

Could you have a review please ?

fgouteroux commented 1 year ago

Hello, any news about this ?

fgouteroux commented 1 year ago

@ponbiki The ns1 api don't remove zone/records tags if the json key tags is not present. As terraform-provider-ns1 is using this library and the dns.Zone/dns.Record model, so we have no control on the marshall/unmarshall json object.

I understand this is a breaking change and maybe it's not the right way. In my opinion, when the api received the payload without json tags key, it should remove all record/zone tags.