ns1 / nsone-python

NS1 Python SDK
https://nsone.net
MIT License
19 stars 20 forks source link

Twisted's transport 2.7 vs 3.X incompatible dict method #18

Closed cpg1111 closed 7 years ago

cpg1111 commented 7 years ago

Within this line https://github.com/ns1/nsone-python/blob/master/nsone/rest/transport/twisted.py#L136, dict#iteritems() is valid in 2.7, but not in 3.X, thus breaking compatibility with 3.X due to dict#iteritems() being replaced with dict#items(). While 2.7 has a dict#items() it does not return an iterator like 3.X's does.